feat: add dockerShmSize option to raise Docker's /dev/shm limit - #81
Merged
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the fix from unity-test-runner#308 (mob-sakai) into the CLI, since build/test logic now lives here rather than in the action repos directly.
What
Unity 6.6 beta / 6.7 alpha editors have been reported to fail against Docker's 64MB default
/dev/shm:Adds a
dockerShmSizeoption (empty/unset by default — matches Docker's own default and doesn't change behavior for editors that don't need it), following the exact pattern of the existingdockerCpuLimit/dockerMemoryLimitoptions. Wired into both the Linux and Windowsdocker runcommand builders inDocker.Why not port the original PR's unconditional
--shm-size=1025mThe original fix hardcoded
--shm-size=1025mon every run. Making it an opt-in flag (--docker-shm-size 1025m) instead avoids silently changing resource allocation for every user on every Unity version, while still giving people hitting this specific error (older/beta editors) a documented way to fix it — same shape as the other Docker resource options already here.Testing
docker.test.ts:--shm-sizeappears on both Linux and Windows commands whendockerShmSizeis set, and is omitted entirely when unset.bun run test— 148 pass, 3 skip, 0 fail.🤖 Generated with Claude Code